Improve spelling#8901
Merged
bramkragten merged 4 commits intohome-assistant:devfrom Apr 13, 2021
LEJOUI:patch-1
Merged
Conversation
frenck
reviewed
Apr 12, 2021
Contributor
Author
|
Thanks for your feedback!
|
Member
|
"Manage integrations that" always sounds as if only a specific subset of all integrations are in there, when if fact all are in there. => I would vote for alternative 1: Manage integrations with services or devices (could also be "and") |
Member
|
It is |
spacegaier
approved these changes
Apr 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
The
...of this line keeps bugging me. It looks unfinished. I'd like to change it in a line that is at least complete.Here's my proposal. Feedback is appreciated.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: